Merged
Conversation
MarcoPolo
force-pushed
the
marco/go-multiaddr-refactor
branch
from
894e6dc to
b434cb2
Compare
MarcoPolo
force-pushed
the
marco/go-multiaddr-refactor
branch
from
bd662af to
e367bc8
Compare
This was referenced Feb 13, 2025
MarcoPolo
changed the title
This was referenced Feb 13, 2025
sukunrt
approved these changes
Feb 13, 2025
Member
sukunrt
left a comment
sukunrt
left a comment
There was a problem hiding this comment.
Some NITs. This is obviously very difficult to review. If there's anything specific you want me to look for I can review again.
| // at appropriate moment a message is sent to dialState.ch to trigger | ||
| // failure | ||
| failDials := make(map[ma.Multiaddr]dialState) | ||
| failDials := make(map[*ma.Multiaddr]dialState) |
Member
There was a problem hiding this comment.
We should add this transform, using the pointer for map key, to release notes if not already added.
Collaborator
Author
There was a problem hiding this comment.
Already called out
Member
|
As there are no changes to go-multiaddr-fmt, does it mean it's already compatible with the new go-multiaddr representation? |
Collaborator
Author
Correct. Already compatible see: multiformats/go-multiaddr-fmt#41 |
MarcoPolo
force-pushed
the
marco/go-multiaddr-refactor
branch
from
ded10c4 to
402b274
Compare
This was referenced Feb 21, 2025
Closed
MarcoPolo
force-pushed
the
marco/go-multiaddr-refactor
branch
from
551c603 to
8bc76c3
Compare
MarcoPolo
force-pushed
the
marco/go-multiaddr-refactor
branch
from
8bc76c3 to
6bccf86
Compare
MarcoPolo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This kicks off the great multiaddr v0.15 rollout to our dependencies. Tracked in multiformats/go-multiaddr#267.
After this PR is approved, I'll release go-multiaddr v0.15 and start the rollout.